Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversations API and locale support (Frontiers announcements) #396

Merged
merged 2 commits into from
Sep 12, 2017

Conversation

aoberoi
Copy link
Contributor

@aoberoi aoberoi commented Sep 12, 2017

New features!

The conversations.* family of web API methods support the new shared channels model. Visit the API website to learn more.

Many methods now have locale support. Some of them didn't make it into this PR (see #395).

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

some methods were omitted because it would introduce an API breaking
change:
*  channels.info
*  groups.info
*  im.open
*  users.info
@codecov
Copy link

codecov bot commented Sep 12, 2017

Codecov Report

Merging #396 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #396   +/-   ##
=======================================
  Coverage   88.96%   88.96%           
=======================================
  Files          44       44           
  Lines        1241     1241           
  Branches      187      187           
=======================================
  Hits         1104     1104           
  Misses        137      137

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5518375...80498a4. Read the comment docs.

Copy link
Contributor

@Roach Roach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aoberoi aoberoi merged commit b447d93 into slackapi:master Sep 12, 2017
@aoberoi aoberoi deleted the conversations-api branch September 12, 2017 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants